TT-7210, TT-7243, TT-7108 Enhance MediaRecord and WSAudioPlayer components with waveform duration management and UI improvements#346
Merged
Conversation
gtryus
commented
Jun 8, 2026
gtryus
commented
Contributor
- Added waveform duration state management in MediaRecord to control save functionality based on audio duration.
- Updated MediaRecord to handle waveform duration changes and reflect this in the save button state.
- Improved UI responsiveness in WSAudioPlayer and SelectVoice components by adjusting layout properties and ensuring proper text wrapping.
- Introduced new tests for MediaRecord to validate save gating behavior based on waveform duration.
…nents with waveform duration management and UI improvements - Added waveform duration state management in MediaRecord to control save functionality based on audio duration. - Updated MediaRecord to handle waveform duration changes and reflect this in the save button state. - Improved UI responsiveness in WSAudioPlayer and SelectVoice components by adjusting layout properties and ensuring proper text wrapping. - Introduced new tests for MediaRecord to validate save gating behavior based on waveform duration.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the renderer’s audio recording/editing flow by tracking waveform duration to prevent saving “empty” audio, and improves several dialog/player layouts to better handle narrow/mobile widths and long text.
Changes:
- Added
waveformDurationstate inMediaRecordto gate save behavior (including disabling waveform save when duration is 0). - Updated
WSAudioPlayer,BigDialog, andSelectVoicelayouts to avoid horizontal overflow and improve text wrapping. - Added unit tests for
MediaRecordto validate save gating based on waveform duration.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/renderer/src/hoc/BigDialog.tsx |
Makes dialog title/description layout shrinkable and enables word wrapping to prevent overflow. |
src/renderer/src/components/WSAudioPlayer.tsx |
Improves AI overlay text wrapping and adjusts voice dialog sizing/behavior for mobile layouts; routes change handling through handleChanged(). |
src/renderer/src/components/MediaRecord.tsx |
Introduces waveform duration tracking to prevent save when duration is 0 and resets duration on reset. |
src/renderer/src/components/MediaRecord.test.tsx |
Adds tests ensuring save is only enabled when waveform duration is positive. |
src/renderer/src/business/voice/SelectVoice.tsx |
Improves responsiveness and wrapping for voice selection UI. |
| </Typography> | ||
| <Divider sx={{ m: 1 }} /> | ||
| <ActionRow> | ||
| <ActionRow sx={{ flexWrap: 'wrap', gap: 1, minWidth: 0 }}> |
sarahentzel
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.