Add custom review instructions to make copilot reviews better#857
Add custom review instructions to make copilot reviews better#857johnml1135 wants to merge 5 commits into
Conversation
Agent-Logs-Url: https://github.com/johnml1135/FieldWorks/sessions/be605597-a9eb-4414-b282-0ffa5ab51938 Co-authored-by: johnml1135 <13733556+johnml1135@users.noreply.github.com>
Agent-Logs-Url: https://github.com/johnml1135/FieldWorks/sessions/be605597-a9eb-4414-b282-0ffa5ab51938 Co-authored-by: johnml1135 <13733556+johnml1135@users.noreply.github.com>
Agent-Logs-Url: https://github.com/johnml1135/FieldWorks/sessions/be605597-a9eb-4414-b282-0ffa5ab51938 Co-authored-by: johnml1135 <13733556+johnml1135@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 7 files and all commit messages, and made 3 comments.
Reviewable status: 7 of 9 files reviewed, all discussions resolved.
.github/copilot-instructions.md line 22 at r2 (raw file):
Framework 4.8 / C# 7.3. - For legacy `.csproj` changes, verify new source files are explicitly included and test sources are explicitly excluded where production and test trees mix.
We souldn't have any legacy .csproj files left, do we?
.github/copilot-instructions.md line 36 at r2 (raw file):
- When those areas change, review null checks, collection bounds, selection state, refresh/invalidation behavior, layout anchoring, localization, and regression-test coverage before style-only concerns.
I'm not sure of the value of this, this will change from week to week.
.github/instructions/fieldworks-interop-review.instructions.md line 25 at r2 (raw file):
where applicable. ## COM and ABI stability
ABI?
|
Devin flaged this saying the yaml list may not get processed, all other places in the file had ',' separated lists. |
|
@jasonleenaylor Follow-up is pushed for the review items.
On the
Docs: https://code.visualstudio.com/docs/copilot/customization/custom-instructions |
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor made 1 comment.
Reviewable status: 7 of 9 files reviewed, all discussions resolved.
Add custom review instructions to make copilot reviews better
This change is