Skip to content

Add custom review instructions to make copilot reviews better#857

Open
johnml1135 wants to merge 5 commits into
sillsdev:mainfrom
johnml1135:copilot/deep-research-review-markdown
Open

Add custom review instructions to make copilot reviews better#857
johnml1135 wants to merge 5 commits into
sillsdev:mainfrom
johnml1135:copilot/deep-research-review-markdown

Conversation

@johnml1135
Copy link
Copy Markdown
Contributor

@johnml1135 johnml1135 commented Apr 30, 2026

Add custom review instructions to make copilot reviews better


This change is Reviewable

Copilot AI and others added 3 commits April 28, 2026 18:55
Agent-Logs-Url: https://github.com/johnml1135/FieldWorks/sessions/be605597-a9eb-4414-b282-0ffa5ab51938

Co-authored-by: johnml1135 <13733556+johnml1135@users.noreply.github.com>
Agent-Logs-Url: https://github.com/johnml1135/FieldWorks/sessions/be605597-a9eb-4414-b282-0ffa5ab51938

Co-authored-by: johnml1135 <13733556+johnml1135@users.noreply.github.com>
Agent-Logs-Url: https://github.com/johnml1135/FieldWorks/sessions/be605597-a9eb-4414-b282-0ffa5ab51938

Co-authored-by: johnml1135 <13733556+johnml1135@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 30, 2026 14:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@johnml1135 johnml1135 changed the title Copilot/deep research review markdown Add custom review instructions to make copilot reviews better May 4, 2026
@johnml1135 johnml1135 requested a review from Copilot May 6, 2026 20:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Comment thread .gitlint Outdated
Comment thread .github/commit-guidelines.md Outdated
Comment thread .github/instructions/fieldworks-parser-utilities-review.instructions.md Outdated
johnml1135 and others added 2 commits May 11, 2026 13:50
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonleenaylor reviewed 7 files and all commit messages, and made 3 comments.
Reviewable status: 7 of 9 files reviewed, all discussions resolved.


.github/copilot-instructions.md line 22 at r2 (raw file):

  Framework 4.8 / C# 7.3.
- For legacy `.csproj` changes, verify new source files are explicitly included
  and test sources are explicitly excluded where production and test trees mix.

We souldn't have any legacy .csproj files left, do we?


.github/copilot-instructions.md line 36 at r2 (raw file):

- When those areas change, review null checks, collection bounds, selection
  state, refresh/invalidation behavior, layout anchoring, localization, and
  regression-test coverage before style-only concerns.

I'm not sure of the value of this, this will change from week to week.


.github/instructions/fieldworks-interop-review.instructions.md line 25 at r2 (raw file):

  where applicable.

## COM and ABI stability

ABI?

@jasonleenaylor
Copy link
Copy Markdown
Contributor

.github/instructions/fieldworks-parser-utilities-review.instructions.md line 6 at r2 (raw file):

  - "Src/Utilities/AlloVarGen/**"
  - "Src/LexText/ParserCore/**"
  - "Src/LexText/Morphology/**"

Devin flaged this saying the yaml list may not get processed, all other places in the file had ',' separated lists.

@johnml1135
Copy link
Copy Markdown
Contributor Author

@jasonleenaylor Follow-up is pushed for the review items.

  • .github/copilot-instructions.md: changed the .csproj guidance to call out native/non-SDK projects specifically.
  • .github/copilot-instructions.md: removed the entire Review focus from recent history section.
  • .github/instructions/fieldworks-interop-review.instructions.md: expanded ABI to binary interface (ABI).

On the applyTo question, I left the YAML list form in place. The VS Code Copilot custom instructions documentation shows both forms as supported:

  • array/list syntax: applyTo: ["src/**", "lib/**"]
  • comma-separated syntax: applyTo: src/**, lib/**

Docs: https://code.visualstudio.com/docs/copilot/customization/custom-instructions

Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

@jasonleenaylor made 1 comment.
Reviewable status: 7 of 9 files reviewed, all discussions resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants