Skip to content

added example for posting a status to facebook using aws lambda#50

Open
mihaiserban wants to merge 4 commits intoserverless:masterfrom
mihaiserban:aws-node_facebook_status
Open

added example for posting a status to facebook using aws lambda#50
mihaiserban wants to merge 4 commits intoserverless:masterfrom
mihaiserban:aws-node_facebook_status

Conversation

@mihaiserban
Copy link
Copy Markdown

No description provided.

@nikgraf
Copy link
Copy Markdown
Contributor

nikgraf commented Jan 14, 2017

this is cool @mihaiserban!

This is missing the serverless.yml. Can you also add a Readme.md explaining how to set Facebook up and use it? Doesn't have to be as detailed as the other Readmes (I can do that), but some guidance would be great. Here the Alexa example readme as inspiration: https://github.com/serverless/examples/blob/master/aws-node-alexa-skill/README.md

@DavidWells
Copy link
Copy Markdown
Contributor

@mihaiserban Can you add in your serverless.yml file?

Then we can merge in.

Thanks!

@nikgraf
Copy link
Copy Markdown
Contributor

nikgraf commented Feb 13, 2017

@DavidWells my initial idea was to keep a very high standard and only have examples with a good Readme. How do you feel about that goal? Should drop it or keep it as a requirement to be merged?

@DavidWells
Copy link
Copy Markdown
Contributor

We need the examples to be complete and deployable. Aka working code and serverless.yml that work with sls deploy

They should have some basic instructions but a comprehensive readme isn't required I'd say

So we can't merge this until the serverless.yml is added =)

Maybe we can take this PR to the finish line

add serverless.yml. add readme, add test event
fix linter errors
@mihaiserban
Copy link
Copy Markdown
Author

@DavidWells updated the pull request, first time using serverless.yml so hope it's ok 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants