Fix github-webhook example#140
Open
maikokuppe wants to merge 2 commits intoserverless:masterfrom
maikokuppe:master
Open
Fix github-webhook example#140maikokuppe wants to merge 2 commits intoserverless:masterfrom maikokuppe:master
maikokuppe wants to merge 2 commits intoserverless:masterfrom
maikokuppe:master
Conversation
Applying JSON.stringify to the raw event body does not work (It is not even a JS object).
The event action was not being logged properly. `event.body` is a string and therefore `event.body.action` is always undefined.
maikokuppe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signature calculation and the logging was not correctly implemented. Take a look at the commits for details.