fix(metrics): drop redundant _seconds suffix on run_duration metric name#29
Merged
fix(metrics): drop redundant _seconds suffix on run_duration metric name#29
Conversation
The metric was declared as `run_duration_seconds` AND given
`metric.WithUnit("s")`. The OTel Prometheus exporter appends `_seconds`
to any metric carrying unit `s`, so this exported as
`seiload_run_duration_seconds_seconds` — a double-suffix that broke
PromQL queries assuming the canonical OTel-conventional name.
Compare with `block_time` in this same file: name `block_time` + unit
`s` exports cleanly as `seiload_block_time_seconds`. Apply the same
convention to `run_duration` so it exports as
`seiload_run_duration_seconds`.
The harbor nightly alert (alerts-nightly.yaml) currently queries the
double-suffixed name; it will be updated in a paired platform-repo PR
that also bumps the pinned seiload image tag, atomically swapping
emitter and consumer.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
amir-deris
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this matters
The harbor nightly alert `NightlyRunFailed` was first written against the double-suffix name (it had to be — that's what was actually exported), making it harder to discover and review. Standardizing to `seiload_run_duration_seconds` aligns with OTel semantic conventions and Prometheus norms.
Coordination
A paired platform-repo PR will atomically:
Both must land in one PR or the alert will spuriously fire (or never fire, depending on which side ships first).
Test plan
🤖 Generated with Claude Code