Skip to content

Add OCC conflict and block execution logs#3376

Open
codchen wants to merge 1 commit intomainfrom
tony/scheduler-conflict-log
Open

Add OCC conflict and block execution logs#3376
codchen wants to merge 1 commit intomainfrom
tony/scheduler-conflict-log

Conversation

@codchen
Copy link
Copy Markdown
Collaborator

@codchen codchen commented May 4, 2026

Summary

  • Adds OCC scheduler conflict-key logging for both sei-cosmos/tasks/scheduler.go and giga/deps/tasks/scheduler.go.
  • Adds ValidateTransactionStateWithKeys so the schedulers can include the conflicting store keys while preserving the existing ValidateTransactionState API.
  • Emits a single aggregated occ scheduler key conflicts log line per block when OCC retries happen, with counts grouped by store/key.
  • Adds an execution block time log at commit with block_txs, process_proposal_ms, finalize_block_ms, commit_ms, and total_execution_ms.

This PR is now logging-only. The original larger PR has been split into:

Test Plan

  • go test ./sei-cosmos/store/multiversion ./sei-cosmos/tasks ./giga/deps/tasks ./sei-cosmos/baseapp

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMay 7, 2026, 4:53 AM

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 64.93506% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.03%. Comparing base (ab54587) to head (8262833).

Files with missing lines Patch % Lines
giga/deps/tasks/scheduler.go 0.00% 24 Missing ⚠️
sei-cosmos/tasks/scheduler.go 87.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3376   +/-   ##
=======================================
  Coverage   59.03%   59.03%           
=======================================
  Files        2105     2105           
  Lines      173300   173363   +63     
=======================================
+ Hits       102312   102353   +41     
- Misses      62104    62126   +22     
  Partials     8884     8884           
Flag Coverage Δ
sei-chain-pr 67.31% <64.93%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-cosmos/baseapp/abci.go 63.00% <100.00%> (+1.07%) ⬆️
sei-cosmos/baseapp/baseapp.go 75.80% <ø> (ø)
sei-cosmos/store/multiversion/store.go 91.96% <100.00%> (+0.29%) ⬆️
sei-cosmos/tasks/scheduler.go 94.88% <87.50%> (-0.74%) ⬇️
giga/deps/tasks/scheduler.go 84.26% <0.00%> (-7.35%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codchen codchen force-pushed the tony/scheduler-conflict-log branch from ee0266f to bbf1182 Compare May 5, 2026 04:29
@codchen codchen changed the title add OCC scheduler key conflict logs and EndBlock latency logs Optimize conflict-heavy EVM transfer block execution May 6, 2026
@codchen codchen force-pushed the tony/scheduler-conflict-log branch from 8d84746 to 9a4abc1 Compare May 6, 2026 03:51
@codchen codchen force-pushed the tony/scheduler-conflict-log branch from 9a4abc1 to 8262833 Compare May 7, 2026 04:52
@codchen codchen changed the title Optimize conflict-heavy EVM transfer block execution Add OCC conflict and block execution logs May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants