fix(ci): paths-filter outputs not propagating to downstream jobs#72
Merged
fix(ci): paths-filter outputs not propagating to downstream jobs#72
Conversation
Composite actions don't propagate dynamic step outputs to the caller — only explicitly declared outputs are visible. Since filter keys are dynamic, switch to calling paths-filter.sh directly in the workflow step so outputs write to the caller's GITHUB_OUTPUT natively.
The script was rewriting the segkit flake ref to path:./segkit which resolves relative to the plugin directory (plugins/android/). Since segkit/ lives at repo root, the correct relative path is ../../segkit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the paths-filter composite action not propagating dynamic outputs to the calling workflow, causing all conditional E2E jobs to skip even when matching files changed (e.g. PR #70).
Changes
paths-filter.shscript called directly by the workflow steprun: bash .github/actions/paths-filter/paths-filter.shinstead ofuses: ./.github/actions/paths-filterWhy
GitHub composite actions only expose outputs explicitly declared in their
outputs:section. Since filter keys are dynamic (defined by the caller), undeclared keys likeandroid,ios,rnwere silently empty. Calling the script directly writes to the caller's$GITHUB_OUTPUTnatively.🤖 Generated with Claude Code