Skip to content

Qtfred error checker#7389

Merged
wookieejedi merged 9 commits into
scp-fs2open:masterfrom
MjnMixael:qtfred-error-checker
May 12, 2026
Merged

Qtfred error checker#7389
wookieejedi merged 9 commits into
scp-fs2open:masterfrom
MjnMixael:qtfred-error-checker

Conversation

@MjnMixael
Copy link
Copy Markdown
Contributor

Activates and greatly enhances the error checker in QtFRED. Instead of just one popup per issue causing an annoying stream of popups this version aggregates all errors and shows them in a single dialog with various error levels. It also tries not to silently modify mission data but has a feature to automatically fix simple problems, changing unclear implicit behavior to explicit.

Part of getting this to work is silencing mission errors during parse so that QtFRED can rely on the error checker to handle that more gracefully. Error Checker here explicitly does not handle mod data related errors so those popups remain. So I've added a QtFred_running variable here so that FRED2's behavior is unaffected. Once FRED2 is fully deprecated, QtFred_running can be merged with Fred_running.

I fully expect the error levels here to be adjusted either during PR review or later during testing. The idea of critical errors, warnings, potential issues, etc was unclear in the old system as it was all sorta jumbled together. The new Error Checker class here tries to unjumble it and make it much clearer to designers what needs to happen with each issue.

I think more can be done here to make this more powerful and clear, but this has grown beyond my original scope already and I think it's in a good enough place to start.

@wookieejedi wookieejedi added the qtfred A feature or issue related to qtFred. label Apr 19, 2026
@github-project-automation github-project-automation Bot moved this to Work In Progress (PRs) in qtFRED2 Apr 19, 2026
@MjnMixael MjnMixael force-pushed the qtfred-error-checker branch 2 times, most recently from adff82e to 5b46bf0 Compare April 23, 2026 15:56
@MjnMixael
Copy link
Copy Markdown
Contributor Author

MjnMixael commented May 3, 2026

This will need help dialog updates

Done

@MjnMixael MjnMixael force-pushed the qtfred-error-checker branch from f7b0d51 to e81bbcf Compare May 4, 2026 14:16
@MjnMixael MjnMixael added this to the Release 26.0 milestone May 7, 2026
Copy link
Copy Markdown
Member

@wookieejedi wookieejedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the cleaned up distinction between errors and warning all looks good to me now

@github-project-automation github-project-automation Bot moved this from Work In Progress (PRs) to In Review (PRs) in qtFRED2 May 11, 2026
@wookieejedi wookieejedi merged commit 6c0d490 into scp-fs2open:master May 12, 2026
30 of 40 checks passed
@github-project-automation github-project-automation Bot moved this from In Review (PRs) to Done in qtFRED2 May 12, 2026
@MjnMixael MjnMixael deleted the qtfred-error-checker branch May 12, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qtfred A feature or issue related to qtFred.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants