Skip to content

CLDSRV-899: Log replication events in server access logs#6164

Open
dvasilas wants to merge 2 commits intodevelopment/9.2from
improvement/CLDSRV-899-log-replication-events
Open

CLDSRV-899: Log replication events in server access logs#6164
dvasilas wants to merge 2 commits intodevelopment/9.2from
improvement/CLDSRV-899-log-replication-events

Conversation

@dvasilas
Copy link
Copy Markdown
Contributor

@dvasilas dvasilas commented May 4, 2026

Replication writes via the backbeat putData route are now visible in
the destination bucket's server access logs.

Reads from the source bucket are already logged as REST.GET.OBJECT.

dvasilas added 2 commits May 4, 2026 16:34
Replication writes via the backbeat putData route are now visible in
bucket server access logs with operation = REST.PUT.OBJECT.
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 4, 2026

Hello dvasilas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 4, 2026

Incorrect fix version

The Fix Version/s in issue CLDSRV-899 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.2.40

  • 9.3.7

  • 9.4.0

Please check the Fix Version/s of CLDSRV-899, or the target
branch of this pull request.

@claude
Copy link
Copy Markdown

claude Bot commented May 4, 2026

LGTM

Clean, well-scoped change. The replication flag flows correctly from putData through getOperation and logServerAccess. The loggingEnabled guard correctly allows replication entries through alongside expiration. The synthesized requestURI matches the pattern used by getURI(). Tests cover the key scenarios including error paths. No issues found.

Review by Claude Code

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.43%. Comparing base (22f67e0) to head (b922c2f).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/routes/routeBackbeat.js 76.79% <100.00%> (+0.06%) ⬆️
lib/utilities/serverAccessLogger.js 83.85% <100.00%> (+0.45%) ⬆️

... and 2 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.2    #6164      +/-   ##
===================================================
- Coverage            84.50%   84.43%   -0.08%     
===================================================
  Files                  204      204              
  Lines                13180    13189       +9     
===================================================
- Hits                 11138    11136       -2     
- Misses                2042     2053      +11     
Flag Coverage Δ
file-ft-tests 68.10% <22.22%> (-0.04%) ⬇️
kmip-ft-tests 28.47% <11.11%> (-0.02%) ⬇️
mongo-v0-ft-tests 69.33% <22.22%> (-0.04%) ⬇️
mongo-v1-ft-tests 69.33% <22.22%> (-0.09%) ⬇️
multiple-backend 35.67% <100.00%> (+0.04%) ⬆️
sur-tests 36.04% <11.11%> (-0.89%) ⬇️
sur-tests-inflights 37.88% <11.11%> (-0.02%) ⬇️
unit 70.30% <88.88%> (+0.01%) ⬆️
utapi-v2-tests 34.77% <11.11%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants