Skip to content

Bump mcvrender and version #80

Merged
sca075 merged 4 commits intomainfrom
dev
May 4, 2026
Merged

Bump mcvrender and version #80
sca075 merged 4 commits intomainfrom
dev

Conversation

@sca075
Copy link
Copy Markdown
Owner

@sca075 sca075 commented May 4, 2026

Solve the rotation trims applied to the image keeping up, left and down, right order correctly.

Summary by CodeRabbit

  • Bug Fixes

    • Fixed room coordinate scaling for Conga vacuum map parsing to ensure proper alignment with original coordinate space.
  • Chores

    • Updated package version and dependencies.

sca075 added 3 commits March 15, 2026 19:07
- Override get_vacuum_points to divide crop_area by CONGA_SCALE,
  restoring calibration points to original vacuum coordinate space.
- Override async_get_rooms_attributes to divide room outline and
  centre x/y by CONGA_SCALE, restoring room data to vacuum space.
- Bump version to 0.3.2.
…3.2 (#77) (#78)

- Override get_vacuum_points to divide crop_area by CONGA_SCALE,
  restoring calibration points to original vacuum coordinate space.
- Override async_get_rooms_attributes to divide room outline and
  centre x/y by CONGA_SCALE, restoring room data to vacuum space.
- Bump version to 0.3.2.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The PR adds coordinate rescaling to the Conga map handler to convert room outline and center coordinates from pre-scaled map space back to original vacuum coordinates by dividing by CONGA_SCALE. Package and module versions are incremented, and the mvcrender dependency is updated.

Changes

Conga Room Coordinate Rescaling

Layer / File(s) Summary
Core Implementation
SCR/valetudo_map_parser/conga_handler.py
CongaMapImageHandler.async_get_rooms_attributes() override divides room outline points and center coordinates (x, y) by CONGA_SCALE using integer division to restore coordinates to vacuum space.
Version & Dependency Updates
pyproject.toml, SCR/valetudo_map_parser/__init__.py
Module version bumped to 0.3.2, package version to 0.3.5, and mvcrender dependency updated to 0.2.5.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

bug

Poem

🐰 Coordinates once lost in scaled space,
Now divided back to their proper place,
With integer division, crisp and true,
Conga rooms find their vacuum view.
Versions bump to mark the care,
A rescaling fix beyond compare!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title mentions bumping 'mcvrender' and version, but the actual changes involve coordinate scaling fixes for the Conga integration and a version bump to 0.3.5, which is only partially reflected in the title. Consider clarifying the title to highlight the main fix (coordinate scaling for Conga rooms) or the complete scope of changes including the scaling adjustments.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch dev

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sca075 sca075 merged commit 608b9a8 into main May 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant