Refactor STS client operation modules#135
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6641d05d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| use crate::sts::types::StsAssumeRoleCredentials; | ||
|
|
||
| /// admin_ops: tenant admin operations (user/policy APIs). | ||
| mod admin_ops; |
There was a problem hiding this comment.
The new split-out STS modules are declared from inside src/sts/rustfs_client.rs, so Rust will look for them under src/sts/rustfs_client/admin_ops.rs (and likewise for s3_ops, pool_ops, sts_ops, core_ops, helpers, and the tests module). I checked the repository file list and these files were added as siblings under src/sts/, so the crate will fail to build with file-not-found module errors until the files are moved under src/sts/rustfs_client/ or each declaration is given the correct #[path = "..."].
Useful? React with 👍 / 👎.
06d3d56 to
9b4b2e2
Compare
9b4b2e2 to
28875de
Compare
Type of Change
Related Issues
Summary of Changes
src/sts/rustfs_client.rsby splitting admin/STS/S3/pool helper logic into dedicated submodules.core_ops.rsandhelpers.rs.RustfsAdminClienttests tosrc/sts/tests.rswhile preserving existing coverage behavior.Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](if user-visible change)Impact
Verification
Additional Notes
my/feature/leader-election.