Skip to content

Refactor STS client operation modules#135

Open
GatewayJ wants to merge 1 commit into
rustfs:mainfrom
GatewayJ:feature/leader-election
Open

Refactor STS client operation modules#135
GatewayJ wants to merge 1 commit into
rustfs:mainfrom
GatewayJ:feature/leader-election

Conversation

@GatewayJ

@GatewayJ GatewayJ commented Jun 8, 2026

Copy link
Copy Markdown
Member

Type of Change

  • Refactor
  • New Feature
  • Bug Fix
  • Documentation
  • Performance Improvement
  • Test/CI
  • Other: N/A

Related Issues

  • N/A

Summary of Changes

  • Reorganize src/sts/rustfs_client.rs by splitting admin/STS/S3/pool helper logic into dedicated submodules.
  • Move shared request-signing and credential/response helpers into core_ops.rs and helpers.rs.
  • Move RustfsAdminClient tests to src/sts/tests.rs while preserving existing coverage behavior.

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines
  • Passed make pre-commit (fmt-check + clippy + test + console-lint + console-fmt-check)
  • Added/updated necessary tests
  • Documentation updated (if needed)
  • CHANGELOG.md updated under [Unreleased] (if user-visible change)
  • CI/CD passed (if applicable)

Impact

  • Breaking change (CRD/API compatibility)
  • Requires doc/config/deployment update
  • Other impact: N/A

Verification

git show --stat --oneline --no-patch

Additional Notes

  • Commit created and pushed to my/feature/leader-election.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6641d05d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/sts/rustfs_client.rs
use crate::sts::types::StsAssumeRoleCredentials;

/// admin_ops: tenant admin operations (user/policy APIs).
mod admin_ops;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fix STS submodule paths

The new split-out STS modules are declared from inside src/sts/rustfs_client.rs, so Rust will look for them under src/sts/rustfs_client/admin_ops.rs (and likewise for s3_ops, pool_ops, sts_ops, core_ops, helpers, and the tests module). I checked the repository file list and these files were added as siblings under src/sts/, so the crate will fail to build with file-not-found module errors until the files are moved under src/sts/rustfs_client/ or each declaration is given the correct #[path = "..."].

Useful? React with 👍 / 👎.

@GatewayJ GatewayJ force-pushed the feature/leader-election branch from 06d3d56 to 9b4b2e2 Compare June 8, 2026 15:36
@GatewayJ GatewayJ force-pushed the feature/leader-election branch from 9b4b2e2 to 28875de Compare June 8, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant