Skip to content

bump rand to 0.9.0#105

Open
TD-Sky wants to merge 1 commit intorust-ndarray:masterfrom
TD-Sky:rand
Open

bump rand to 0.9.0#105
TD-Sky wants to merge 1 commit intorust-ndarray:masterfrom
TD-Sky:rand

Conversation

@TD-Sky
Copy link
Copy Markdown

@TD-Sky TD-Sky commented Feb 25, 2025

No description provided.

@TD-Sky
Copy link
Copy Markdown
Author

TD-Sky commented Mar 10, 2025

@bluss Would you kindly review and release a new patch version if possible?

@miikkas
Copy link
Copy Markdown

miikkas commented Oct 18, 2025

I did similar changes independently and successfully ran cargo test before checking if a PR was already up.

Some additional things of note that I think should not block merging this, since they are testing or benchmarking related:

  • ndarray-rand, currently with released version 0.15.0, is used for tests. That version of the crate uses rand 0.8, but the version on the main branch already uses 0.9.
    • When a new version of ndarray-rand is released and the version in ndarray-stats is bumped to that, some of the tests and benches need to have the results from Uniform::new handled, I think by just unwrapping.
  • quickcheck version 0.9.2, also for tests, uses rand 0.7. The latest released version 1.0.3 uses rand 0.8. Their current main branch uses 0.9.
    • Bumping quickcheck currently causes some new test failures. Possibly seems like its rummaging through more floating point numbers than previous versions. However, the failures I observed were due to stuff like NaNs, infs, or huge values around 10308.

@miikkas
Copy link
Copy Markdown

miikkas commented Apr 24, 2026

@TD-Sky Would you be willing to rebase this PR on top of the current master branch, since there has been a release since your original changes?

There seems to also be a new release of rand, 0.10.1. I was able to get it working in this branch just by setting the version of rand to ">= 0.9.0, <= 0.10" in Cargo.toml. That is, at least running cargo test passed successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants