deprecate non_ssl port in fts-messaging in favor of just port#787
Open
panta-123 wants to merge 1 commit intorucio:mainfrom
Open
deprecate non_ssl port in fts-messaging in favor of just port#787panta-123 wants to merge 1 commit intorucio:mainfrom
panta-123 wants to merge 1 commit intorucio:mainfrom
Conversation
voetberg
reviewed
May 1, 2026
| - **use_ssl**: _(Optional)_ Boolean. Default: `True`. | ||
| - **port** Port of the broker if `use_ssl` is set. | ||
| - **port** Port of the broker. | ||
| Before release-41.0.0, used only for the SSL connection `use_ssl=True`. |
Contributor
There was a problem hiding this comment.
Hm, this wording is sort of confusing. Can I recommend just pointing to the nonssl_port instead? So:
Suggested change
| Before release-41.0.0, used only for the SSL connection `use_ssl=True`. | |
| Port of the broker. For >=41.0.0, used for all connections. See `nonssl_port`. |
voetberg
reviewed
May 1, 2026
| `ssl_cert_file` if `use_ssl` is set. No default. | ||
| - **nonssl_port**: _(Optional)_ Port of the broker if `use_ssl` is not set. | ||
| - **nonssl_port**: _(Optional)_ (Deprecated from release 41) | ||
| Previously used when `use_ssl` was disabled. This option is no longer required and is ignored in favor of port. |
Contributor
There was a problem hiding this comment.
Suggested change
| Previously used when `use_ssl` was disabled. This option is no longer required and is ignored in favor of port. | |
| For <41.0.0, used to specify ports when `use_ssl`=False. See `port`. |
panta-123
force-pushed
the
deprecate-warnng-for-nonssl_port-#780
branch
from
d008224 to
f6fb1be
Compare
panta-123
force-pushed
the
deprecate-warnng-for-nonssl_port-#780
branch
from
f6fb1be to
16e0d30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added release before and from to add warning and changes.
not sure thats the right way, leaving it to the reviewer to comment
docs of rucio/rucio#8488