Skip to content

Extend Node#set with additional input types #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
duncan-bayne wants to merge 7 commits into
base: main
Choose a base branch
from
+37 −2
Open

Extend Node#set with additional input types #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
343ed98
Implement date input types based on the capybara selenium driver
DanielHeath Mar 21, 2025
6e4da4d
Make fixture form valid HTML
duncan-bayne Mar 25, 2025
c7a2a76
Add specs for additional set types
duncan-bayne Mar 25, 2025
91ae481
Merge branch 'main' into extend-set
duncan-bayne May 4, 2026
7174e46
Remove dead code
duncan-bayne May 4, 2026
9a9a9c0
Remove redundant when clause
duncan-bayne May 4, 2026
d41d77e
Ignore additional complexity metric
duncan-bayne May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/capybara/cuprite/node.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def value
command(:value)
end

def set(value, options = {}) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
def set(value, options = {}) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/AbcSize
warn "Options passed to Node#set but Cuprite doesn't currently support any - ignoring" unless options.empty?

if tag_name == "input"
Expand All @@ -115,6 +115,9 @@ def set(value, options = {}) # rubocop:disable Metrics/CyclomaticComplexity, Met
when "week"
value = value.to_date.strftime("%G-W%V") if !value.is_a?(String) && value.respond_to?(:to_date)
command(:set, value.to_s)
when "datetime-local"
value = value.to_time.strftime("%Y-%m-%dT%H:%M") if !value.is_a?(String) && value.respond_to?(:to_time)
command(:set, value.to_s)
else
command(:set, value.to_s)
end
Expand Down
24 changes: 24 additions & 0 deletions spec/features/driver_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1482,6 +1482,30 @@ def create_screenshot(file, *args)
expect(input.text).to eq("replacement text")
end

it "sets a date field" do
Copy link
Copy Markdown
Author

@duncan-bayne duncan-bayne May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to leave these in as there wasn't test coverage, even though support for setting most of these has already been added upstream.

input = @session.find(:css, "#date-field")
input.set(Time.new(2000, 12, 31))
expect(input.value).to eq("2000-12-31")
end

it "sets a datetime-local field" do
input = @session.find(:css, "#datetime-local-field")
input.set(Time.new(2000, 12, 31, 17, 15))
expect(input.value).to eq(Time.new(2000, 12, 31, 17, 15).strftime("%Y-%m-%dT%H:%M"))
end

it "sets a range field" do
input = @session.find(:css, "#range-field")
input.set(42)
expect(input.value).to eq("42")
end

it "sets a color field" do
input = @session.find(:css, "#color-field")
input.set("#1270a4")
expect(input.value).to eq("#1270a4")
end

it "sets a content editable childs content" do
@session.visit("/with_js")
@session.find(:css, "#existing_content_editable_child").set("WYSIWYG")
Expand Down
10 changes: 9 additions & 1 deletion spec/support/views/set.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml" lang="en">
<head>
<meta http-equiv="Content-type" content="text/html; charset=utf-8"/>
<meta http-equiv="Content-type" content="text/html; charset=utf-8">
<title>Set tests</title>
</head>

<body>
<div id="empty_div" contenteditable="true"></div>
<div id="filled_div" contenteditable="true">Content</div>
<form>
<input id="date-field" type="date" name="date-field"><br>
<input id="datetime-local-field" type="datetime-local" name="datetime-local-field"><br>
<input id="range-field" type="range" min="0" max="100" name="range-field"><br>
<input id="color-field" type="color" name="color-field">
</form>
</body>
</html>
Loading