Update File::Constants and File::Stat#2942
Open
sampersand wants to merge 4 commits intoruby:masterfrom
Open
Conversation
sampersand
changed the title
sampersand
force-pushed
the
swesterman/2026-04-28/update-File-constants-and-stat
branch
from
8dee6f9 to
d532855
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up miscellaneous
FileRBS definitions:File's top-level constants,File::ConstantsandFile::Stat(which were mostly correct, barirng a few nilable values). This is in preparation for another subsequent PR which will update the coreFileclass.Also note that this PR splits
File::ConstantsandFile::Statinto their owncore/file_{constants,stat}.rbsfiles. If that's not desired, I can stick them back incore/file.rbs, but I think it's cleaner to have them as separate files. (And, we already have separate test files for them anyways, so it makes sense.)