refactor: rename overloaded constructors to from* names [codex]#255
Open
jderochervlk wants to merge 25 commits intomainfrom
Open
refactor: rename overloaded constructors to from* names [codex]#255jderochervlk wants to merge 25 commits intomainfrom
jderochervlk wants to merge 25 commits intomainfrom
Conversation
Port the surviving API cleanup from the final pre-alpha branch onto the monorepo split introduced in #249. This adds the missing concrete modules, translates the fetch/runtime/canvas/websocket/media surface cleanup into the package layout, and keeps the branch green with updated tests.
Drop scroll2/scrollTo2/scrollBy2 and keep the descriptive *XY overload names requested in review. Co-authored-by: Codex <codex@openai.com>
…with-commits-and-responses Address review feedback: rename constructors, unbox FormDataEntryValue, reuse MessageEvent types, simplify tests
…-webapi into codex/issue-236-constructor-from-names-carryover
jderochervlk
commented
Apr 20, 2026
Update DOMMatrix, DOMMatrixReadOnly, Path2D, and ReadableStream single-source constructor overloads to take direct unlabeled arguments. Refresh compile-coverage tests and contributor documentation to match the constructor naming convention.
jderochervlk
commented
Apr 20, 2026
jderochervlk
commented
Apr 20, 2026
jderochervlk
commented
Apr 20, 2026
Remove source-shape callouts from the constructor docs added in this PR. Rewrite constructor summaries to focus on the ReScript API surface and update the contributor documentation guidance to match.
Collaborator
Author
jderochervlk
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c7ece03a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tsnobip
requested changes
Apr 23, 2026
Member
tsnobip
left a comment
tsnobip
left a comment
There was a problem hiding this comment.
except from the sharedArrayBuffer, the rest looks good to me!
Replace the unknown SharedArrayBuffer-only constructor surface with a typed-array overload alongside the existing ArrayBuffer and DataView bindings. Update the compile-coverage test to exercise the new VideoFrame.fromTypedArray binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from*source-type namesmake()VideoFramepixel-data constructors as separateArrayBuffer,TypedArray, andDataViewbindingsmainValidation
npm testnpm run format:checkASTRO_TELEMETRY_DISABLED=1 npm run build:docs