Part d and e - link to details and other changes (#9329)#223
Open
keithchong wants to merge 1 commit intoredhat-developer:mainfrom
Open
Part d and e - link to details and other changes (#9329)#223keithchong wants to merge 1 commit intoredhat-developer:mainfrom
keithchong wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
keithchong
changed the title
keithchong
changed the title
Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong
force-pushed
the
9329-PartDandE-LinkToDetailsAndOtherChanges
branch
from
5c1d5e7 to
8ce6d6e
Compare
Collaborator
Author
|
Hi @aali309 , I've rebased and this has the fixes for parts d and e only now. |
aali309
reviewed
Apr 24, 2026
Collaborator
aali309
left a comment
aali309
left a comment
There was a problem hiding this comment.
Just one NIT comment, otherwise LGTM!
| case t('Edit annotations'): | ||
| launchAnnotationsModal(); | ||
| break; | ||
| case t('Edit Application'): |
Collaborator
There was a problem hiding this comment.
The lines 208–212 (unreachable code) could be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should not have any conflicts once
#221
#222
are merged.
This PR is for parts D and E. See GITOPS-9329 for details