Minor fixes to player#2756
Open
Luna712 wants to merge 5 commits intorecloudstream:masterfrom
Open
Conversation
Collaborator
|
Please give a brief summery of what this is doing and why, so I can better review and test! |
Contributor
Author
Done though would also like to note the isClickable fixes here I am unsure if that is the right way to fix it as while it stops it from play pausing etc... when controls are not showing, for about 0.2 seconds, clicking in the center were doesn't show the controls again, so that tells me the isClickable fix is only going to mask the issue and there is likely some other underlying issue. But I am not quite sure what. UPDATE: I decided to remove that part for now, we can look into that issue more later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Sometimes the play pause or fast forward/rewind buttons would be clicked again even after they had already hidden (usually only for about 0.2 seconds though)(not doing in this for now as I don't think it is a proper fix)setOnClickListenerforplayerPausePlay(one inPlayerViewand one inFullScreenPlayer) - the one inPlayerViewaccidentally omitted theisLayout(PHONE)check, causing phone-only behavior to also apply on TV and EmulatorFullScreenPlayer(not trailer)FullScreenPlayer