Skip to content

Minor fixes to player#2756

Open
Luna712 wants to merge 5 commits intorecloudstream:masterfrom
Luna712:player-fixes
Open

Minor fixes to player#2756
Luna712 wants to merge 5 commits intorecloudstream:masterfrom
Luna712:player-fixes

Conversation

@Luna712
Copy link
Copy Markdown
Contributor

@Luna712 Luna712 commented May 3, 2026

Fixes:

  • Shadow overlay not properly hidden (except in trailer player)
  • Sometimes the play pause or fast forward/rewind buttons would be clicked again even after they had already hidden (usually only for about 0.2 seconds though) (not doing in this for now as I don't think it is a proper fix)
  • Duplicate setOnClickListener for playerPausePlay (one in PlayerView and one in FullScreenPlayer) - the one in PlayerView accidentally omitted the isLayout(PHONE) check, causing phone-only behavior to also apply on TV and Emulator
  • Buffer icon sometimes overlaps play/pause in FullScreenPlayer (not trailer)
  • 2x speed on trailer not hiding controls, an inconsistent behavior from FullScreenPlayer
  • UI not showing after gesture end if it was visible before while paused (trailer-only)

@fire-light42
Copy link
Copy Markdown
Collaborator

Please give a brief summery of what this is doing and why, so I can better review and test!

@Luna712
Copy link
Copy Markdown
Contributor Author

Luna712 commented May 3, 2026

Please give a brief summery of what this is doing and why, so I can better review and test!

@fire-light42

Done though would also like to note the isClickable fixes here I am unsure if that is the right way to fix it as while it stops it from play pausing etc... when controls are not showing, for about 0.2 seconds, clicking in the center were doesn't show the controls again, so that tells me the isClickable fix is only going to mask the issue and there is likely some other underlying issue. But I am not quite sure what.

UPDATE: I decided to remove that part for now, we can look into that issue more later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants