Promote AcraApplication deprecations to error level#2630
Open
Luna712 wants to merge 1 commit intorecloudstream:masterfrom
Open
Promote AcraApplication deprecations to error level#2630Luna712 wants to merge 1 commit intorecloudstream:masterfrom
Luna712 wants to merge 1 commit intorecloudstream:masterfrom
Conversation
I know this is really early, but I personally PRed replacements for these to ever single repo that used AcraApplication and listed in recloudstream/cs-repos. Therefore to make it less likely something starts using it again, I would prefer to do this earlier now, since it only affects build, not runtime.
Contributor
Author
|
That is absolutely fair and makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this is really early, but I personally PRed replacements for these to every single repo that used AcraApplication and listed in recloudstream/cs-repos. Therefore to make it less likely something starts using it again, I would prefer to do this earlier now, since it only affects build, not runtime.
If you decide you don't want to yet that is understandable, and this can be closed.