Detect updates to dynamic recurring tasks on poll#739
Open
cupatea wants to merge 1 commit intorails:mainfrom
Open
Detect updates to dynamic recurring tasks on poll#739cupatea wants to merge 1 commit intorails:mainfrom
cupatea wants to merge 1 commit intorails:mainfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #738
Scheduler::RecurringSchedule#reschedule_dynamic_tasks previously only detected created and deleted dynamic tasks. Updates to an existing task's were ignored, so the scheduler kept running against the pre-update version until restart.
Approach:
Each entry in scheduled_tasks is now a ScheduledRecurringTask struct that pairs the
Concurrent::ScheduledTaskhandle with the sourceRecurringTaskAR record:Add new step
reschedule_dynamic_tasksthat replaces any tasks withupdated_atdiffers from the cached ones.