Skip to content

fix pyright version parsing #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 1 commit into from
Apr 25, 2026
+10 −1
Merged

fix pyright version parsing #2273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion conformance/src/type_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,16 @@ def get_version(self) -> str:
stdout=PIPE,
text=True,
)
return proc.stdout.strip()
return self._parse_version(proc.stdout)

@staticmethod
def _parse_version(output: str) -> str:
# pyright --version can print an update message ("there is a new pyright version available"),
# make sure we extract only the actual version
for line in output.splitlines():
if line.startswith("pyright "):
return line
return output.strip()

def run_tests(self, test_files: Sequence[str]) -> dict[str, str]:
command = [sys.executable, "-m", "pyright", ".", "--outputjson"]
Expand Down