Handle reachability consistently in two-phase checking#21322
Merged
ilevkivskyi merged 1 commit intopython:masterfrom Apr 25, 2026
Merged
Handle reachability consistently in two-phase checking#21322ilevkivskyi merged 1 commit intopython:masterfrom
ilevkivskyi merged 1 commit intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have this (somewhat questionable) behaviour of not checking unreachable code. Surprisingly many repos rely on this. Thus we should preserve this behaviour in two-phase checking, which means skip top-level definitions that were found unreachable.
I tried few approaches, and using line numbers seems to be the simplest one.
cc @JukkaL