gh-151179: Fix pidfd leak in asyncio _PidfdChildWatcher#151186
Open
deadlovelll wants to merge 3 commits into
Open
gh-151179: Fix pidfd leak in asyncio _PidfdChildWatcher#151186deadlovelll wants to merge 3 commits into
deadlovelll wants to merge 3 commits into
Conversation
deadlovelll
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
| returncode = waitstatus_to_exitcode(status) | ||
|
|
||
| os.close(pidfd) | ||
| try: |
Contributor
There was a problem hiding this comment.
Why adding nested exception handler? You could just put os.close in finally block.
Contributor
Author
There was a problem hiding this comment.
Good point - fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PidfdChildWatcher._do_wait()leftos.close(pidfd)outside the cleanup path. The pidfd leaked whenwaitpid()raising anything other thanChildProcessError. Movingos.close()into afinallyblock closes the descriptor while still letting the exception propagate.For more details see gh-151179