gh-148849: Deprecate http.cookies.BaseCookie.js_output()#148978
gh-148849: Deprecate http.cookies.BaseCookie.js_output()#148978kishorhange111 wants to merge 7 commits intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Please, do not update your branch if there is no need to. Please read https://devguide.python.org/getting-started/pull-request-lifecycle/ before doing future contributions. |
| The meaning for *attrs* is the same as in :meth:`output`. | ||
|
|
||
| .. deprecated-removed:: next 3.19 | ||
| :meth:`!js_output` is deprecated and will be removed in Python 3.19. |
There was a problem hiding this comment.
This sentence is redundant, the directive renders as "will be removed in Python 3.19" anyway.
There was a problem hiding this comment.
Thanks for pointing that out! Just to confirm — should I remove the “will be removed in Python 3.19” part entirely and keep only the deprecation directive?
Happy to update it accordingly.
kishorhange111
force-pushed
the
gh-148849-deprecate-js-output
branch
from
d9ae235 to
d1e4a57
Compare
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @picnixz: please review the changes made to this pull request. |
|
Please let me know if there are any further suggestions or changes needed. |
Co-authored-by: Stan Ulbrych <stan@python.org>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
3 participants
gh-148849: Deprecate http.cookies.BaseCookie.js_output()
I didn’t see anyone assigned to this issue, so I tried working on it. I’m new to open source contributions, so please let me know if anything should be done differently.
This deprecates
BaseCookie.js_output()as discussed in the issue. The method seems to be unused and tied to older browser behavior that isn’t really relevant anymore.I added a deprecation decorator to the method, updated the existing tests to expect a
DeprecationWarning, and updated the docs along with a NEWS entry.I ran
test_http_cookieslocally — all tests pass (33 tests, 1 skipped):I also checked that calling
js_output()raises the warning while still returning the same result.I left
Morsel.js_output()unchanged since the issue only mentionsBaseCookie.js_output(), but I can update that too if needed.Would appreciate a review whenever you get a chance. Thanks!
Fixes gh-148849
📚 Documentation preview 📚: https://cpython-previews--148978.org.readthedocs.build/