Skip to content

gh-140727: Update tachyon logo#148965

Open
maigimenez wants to merge 2 commits intopython:mainfrom
maigimenez:tachyon_vector
Open

gh-140727: Update tachyon logo#148965
maigimenez wants to merge 2 commits intopython:mainfrom
maigimenez:tachyon_vector

Conversation

@maigimenez
Copy link
Copy Markdown

@maigimenez maigimenez commented Apr 24, 2026

Summary

Updates the Tachyon logo with a vectorial design and refreshed colors

Changes

The previous logo design was a draft that needed to be updated with the final version. Updated:

  • Doc/library/tachyon-logo.png
  • Lib/profiling/sampling/_assets/tachyon-logo.png

with new design and colors

And verified that locally the logo renders correctly:

cd Doc
make venv
make html
open build/html/library/profiling.sampling.html

See gh-140727.


📚 Documentation preview 📚: https://cpython-previews--148965.org.readthedocs.build/

@bedevere-app

This comment was marked as resolved.

Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please optimise the images, unless you already have? (E.g. with OptiPNG: find . -name '*.png' | xargs optipng -o7) If you're unable to please let me know and I can do it.

@maigimenez
Copy link
Copy Markdown
Author

Done! Thanks for the suggestion! Let me know if there's something else I can do to help

Comment thread Doc/library/tachyon-logo.png Outdated
@maigimenez
Copy link
Copy Markdown
Author

Yep, they were indeed identical. I should have thought about it 🙈 Thanks!

@StanFromIreland
Copy link
Copy Markdown
Member

No worries! Thanks for making the changes, just a little note for the future, please avoid force pushing.

Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, I'll leave this for Pablo.

--------------

.. image:: tachyon-logo.png
.. image:: ../../Lib/profiling/sampling/_assets/tachyon-logo.png
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CAn't we leave the old link? I don't really like having this path hardcoded.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a strong opinion here, but we can either have a replicate image in two places or having a link to the second lib, or I'm not seeing how to do both :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err, what I meant is that I would have preferred to keep tachyon-logo.png as the image's directive argument and not the ../../Lib/profiling/sampling/_assets/tachyon-logo.png one. The Sphinx docs should have added the asset path in conf.py I think?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, there were TWO files. Ok. I think you can just add Lib/profiling/sampling/_assets as an asset to search within for Sphinx to pick it up. It's been a while since I played with assets so I may have missed something.

@StanFromIreland
Copy link
Copy Markdown
Member

Please avoid using the Update Branch button unless necessary (e.g. fixing conflicts or jogging the CI) as it uses valuable resources. For more information please see the devguide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants