Open
Conversation
* SEND_VIRTUAL: for sends to virtual iterators e.g lists and tuples * SEND_ASYNC_GEN: for sends to async generators Tweak FOR_ITER_VIRTUAL so that SEND_VIRTUAL and FOR_ITER_VIRTUAL use equivalent guards
markshannon
requested review from
Fidget-Spinner,
brandtbucher,
diegorusso,
iritkatriel,
savannahostrowski and
tomasr8
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 2 new specialized instructions:
SEND_VIRTUALfor sends to virtual iterators e.g lists and tuplesSEND_ASYNC_GENfor sends to async generatorsAlso, tweaks
FOR_ITER_VIRTUALso thatSEND_VIRTUALandFOR_ITER_VIRTUALuse equivalent guardsThis is aimed more at JIT coverage, especially ensuring that we can trace through
SENDinstructions, than interpreter performance.Performance is broadly neutral, but with improvements of 4-6% on the
async_generatorsbenchmark.