gh-141444: Fix dead URLs in urllib documentation#148952
gh-141444: Fix dead URLs in urllib documentation#148952ZLeventer wants to merge 1 commit intopython:mainfrom
Conversation
Replace dead/broken URLs in urllib documentation: - urllib.request.rst: Replace musi-cal.com (503) with python.org/search for GET example - urllib.request.rst: Replace requestb.in (403) with httpbin.org/post for POST example - urllib.robotparser.rst: Replace robotstxt.org/orig.html with RFC 9309 reference, which is the authoritative IETF standard for robots.txt
| questions about whether or not a particular user agent can fetch a URL on the | ||
| website that published the :file:`robots.txt` file. For more details on the | ||
| structure of :file:`robots.txt` files, see http://www.robotstxt.org/orig.html. | ||
| structure of :file:`robots.txt` files, see :rfc:`9309`. |
There was a problem hiding this comment.
This is a separate issue, please revert.
| >>> data = urllib.parse.urlencode({'spam': 1, 'eggs': 2, 'bacon': 0}) | ||
| >>> data = data.encode('ascii') | ||
| >>> with urllib.request.urlopen("http://requestb.in/xrbl82xr", data) as f: | ||
| >>> with urllib.request.urlopen("https://httpbin.org/post", data) as f: |
There was a problem hiding this comment.
How trusted is that URL? is it the URL that is used by testing in general? is there some "example.net" alternative?
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Summary
Replace dead/broken URLs in urllib documentation files:
Doc/library/urllib.request.rst: Replacemusi-cal.com(returns 503) withpython.org/searchin the GET example, and replacerequestb.in(returns 403) withhttpbin.org/postin the POST exampleDoc/library/urllib.robotparser.rst: Replace barehttp://www.robotstxt.org/orig.htmlURL with an:rfc:9309`` reference — RFC 9309 ("Robots Exclusion Protocol") is the authoritative IETF standard for robots.txtCloses #141444
Closes #141412
📚 Documentation preview 📚: https://cpython-previews--148952.org.readthedocs.build/