-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
gh-47798: Add a subprocess.run_pipeline() API
#142080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gpshead
wants to merge
31
commits into
python:main
Choose a base branch
from
gpshead:claude/subprocess-pipe-chaining-01R27VPueru4RfRXYDsV5TmW
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
e3a2fbe
Add subprocess.run_pipeline() for command pipe chaining
gpshead 4feb2a8
Add documentation for subprocess.run_pipeline()
gpshead 2a11d4b
Refactor run_pipeline() to use multiplexed I/O
gpshead 2470e14
Add deadlock prevention tests for run_pipeline()
gpshead e22d1da
Simplify _communicate_streams() to only accept file objects
gpshead a3e98a7
Improve test_pipeline_large_data_with_stderr to use large stderr
gpshead 3c28ed6
Remove obsolete XXX comment about non-blocking I/O
gpshead 9f53a8e
Refactor POSIX communicate I/O into shared _communicate_io_posix()
gpshead d420f29
Fix _communicate_streams_windows to avoid blocking with large input
gpshead df8f082
Fix memoryview and closed stdin handling in _communicate_streams_posix
gpshead 978cd76
Factor out _flush_stdin() and _make_input_view() helpers
gpshead 15f8a93
Support universal_newlines and use _translate_newlines in run_pipeline
gpshead e6a78a9
Merge remote-tracking branch 'origin/main' into claude/subprocess-pip…
gpshead 5bc5be4
gh-47798: Fix run_pipeline text-mode breaking the Windows backend
gpshead ae3ee12
gh-47798: Fix TimeoutExpired.output picking wrong stream in run_pipeline
gpshead 11ada45
gh-47798: Reject stdin=PIPE in run_pipeline()
gpshead 51e1ae2
gh-47798: Reject close_fds=False in run_pipeline()
gpshead c218959
gh-47798: run_pipeline: small correctness cleanups
gpshead a348976
gh-47798: run_pipeline: kill all children before waiting on any
gpshead 8b953b0
gh-47798: run_pipeline: small style cleanups
gpshead 5175866
gh-47798: Document stderr=STDOUT behavior and add NEWS entry
gpshead bbdbd93
gh-47798: run_pipeline: cover gaps in test coverage
gpshead 499ea81
gh-47798: Rename PipelineResult to CompletedPipeline
gpshead fd0231e
gh-47798: run_pipeline: small style and consistency nits
gpshead 6e53bb9
gh-47798: run_pipeline: documentation gap fixes
gpshead 56bbd4a
gh-47798: Restore close-on-EOF in Popen._communicate via factored helper
gpshead 7ea824a
gh-47798: Test Popen.communicate resume after partial-write timeout
gpshead 0091aa8
gh-47798: run_pipeline: cover shell, env, cwd, pass_fds forwarding
gpshead 208c4ae
gh-47798: run_pipeline: cover stderr=PIPE success, errors=replace, br…
gpshead f3e0fea
gh-47798: Fix flake in test_pipeline_pass_fds
gpshead e65e55d
gh-47798: Cover Windows backend timeout in run_pipeline tests
gpshead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.