ci: replace deployment action with builtin deployment support#218
Draft
ci: replace deployment action with builtin deployment support#218
Conversation
|
Deploy preview for website ready!
Deployed with vercel-action |
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions deployment workflows to stop using the bobheadxi/deployments action (flagged for Node.js 20 deprecation / likely unmaintained) and instead use GitHub’s built-in Environment deployment tracking by attaching environment metadata to the deployment jobs.
Changes:
- Add
environment.nameandenvironment.urlto Preview and Production deployment jobs. - Remove
bobheadxi/deploymentsstart/finish steps and the associateddeployments: writepermission.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/deploy-production.yaml | Switches production workflow from custom deployments action to GitHub Environment metadata (name + URL), removing deployments action steps/permissions. |
| .github/workflows/deploy-preview.yaml | Switches preview workflow from custom deployments action to GitHub Environment metadata (name + URL), removing deployments action steps/permissions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+18
to
+20
| environment: | ||
| name: Production | ||
| url: ${{ steps.vercel-action.outputs.preview-url }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We get the following warning in our actions:
bobheadxi/deploymentsmay be unmaintained:However, we probably do not even need a custom action but can just rely on github's builtin deployment mechanism.