Add tee-fd capture mode and capteefd fixtures#14432
Open
FazeelUsmani wants to merge 12 commits intopytest-dev:mainfrom
Open
Add tee-fd capture mode and capteefd fixtures#14432FazeelUsmani wants to merge 12 commits intopytest-dev:mainfrom
FazeelUsmani wants to merge 12 commits intopytest-dev:mainfrom
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
… into tee-fd-capture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements
--capture=tee-fdmode andcapteefd/capteefdbinaryfixtures, addressing issue #14159.The new capture mode enables FD-level capture (including subprocess output) while simultaneously passing output through to the terminal in real-time.
closes #14159
Changes
--capture=tee-fdCLI optioncapteefdandcapteefdbinaryfixturesFDCaptureTeeandFDCaptureBinaryTeeclasses using pipe+thread architectureselect) and Windows (using queue-based approach)Test Plan
pytest testing/test_capture.py::TestFDCaptureTee- 11 tests passpytest testing/test_capture.py::TestCaptureFixture::test_capteefd- fixture tests pass