refactor: add MaxFrameLimit to libp2p connections#228
Merged
Aman035 merged 3 commits intoaudit-fixesfrom May 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 MiB cap on frames is added. The length prefix is checked against the cap before any allocation, and the underlying reader is wrapped in a limit reader as defense-in-depth. The send path carries the same cap.
1 MiB is sized off measurement - an end-to-end DKLS keygen + sign for a 100-party committee (t=67) produced a max single message of ~39 KiB (keygen) and ~48 KiB (sign), so 1 MiB is ~20× headroom.