docs: clarify cleaning PROMETHEUS_MULTIPROC_DIR#1167
Open
ayushanand293 wants to merge 1 commit intoprometheus:masterfrom
Open
docs: clarify cleaning PROMETHEUS_MULTIPROC_DIR#1167ayushanand293 wants to merge 1 commit intoprometheus:masterfrom
ayushanand293 wants to merge 1 commit intoprometheus:masterfrom
Conversation
Signed-off-by: Ayush Anand <ayushanand293@gmail.com>
ayushanand293
force-pushed
the
docs/931-multiproc-cleanup
branch
from
dbaf533 to
af766ef
Compare
Comment on lines
+42
to
+43
| rm -rf "$PROMETHEUS_MULTIPROC_DIR" | ||
| mkdir -p "$PROMETHEUS_MULTIPROC_DIR" |
Member
There was a problem hiding this comment.
Suggested change
| rm -rf "$PROMETHEUS_MULTIPROC_DIR" | |
| mkdir -p "$PROMETHEUS_MULTIPROC_DIR" | |
| rm "$PROMETHEUS_MULTIPROC_DIR/*.db" |
This might be a bit safer, and one less thing to do. I also wonder if the example should be in python rather than asking people to run bash before starting python?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document a recommended startup cleanup pattern for
PROMETHEUS_MULTIPROC_DIRto avoid stale metrics across restarts.Closes #931.
Checklist
python -m pytest -q).