add codesign verify step for mac builds#1509
Open
kjhollen wants to merge 1 commit intoprocessing:mainfrom
Open
add codesign verify step for mac builds#1509kjhollen wants to merge 1 commit intoprocessing:mainfrom
kjhollen wants to merge 1 commit intoprocessing:mainfrom
Conversation
and use verbose output so that during release actions, someone can get a little info to debug the issue even if they don't have a mac. this ended up being implemented in the gradle build file instead of the release.yml file, because the Build with Gradle step (which is `./gradlew packageDistributionForCurrentOS`) includes both signing and notarization. to stop the build early if the app signing failed, the intervening check had to be inserted into the normal build process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and use verbose output so that during release actions, someone can get a little info to debug the issue even if they don't have a mac.
this ended up being implemented in the gradle build file instead of the release.yml file, because the Build with Gradle step (which is
./gradlew packageDistributionForCurrentOS) includes both signing and notarization. to stop the build early if the app signing failed, the intervening check had to be inserted into the normal build process.