-
Notifications
You must be signed in to change notification settings - Fork 28
feat: "quickstart" and "deploy pyproject" commands #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
404d2f2
Probe driven development plan
amol- 65c39e1
rsconnect quickstart stub handler
amol- 788b8de
expose deploy pyproject command
amol- 0463a65
Implement deploy pyproject
amol- 781fd7f
setup the quickstart command infrastructure
amol- 4665a85
basic templating infrastructure
amol- 763fa55
encapsulate templates
amol- 488b274
Quickstart command in place and working
amol- a5ddf6b
quickstart templates for quarto, fastapi, jupyter, shiny
amol- d3f76aa
documentation of quickstart command
amol- 2add7e7
quickstart command docs with testing infrastructure
amol- dfe5a0a
note about the known risk in tests, it's acceptable
amol- 1016e7c
Preparing for graduation
amol- 08ca559
use older click version
amol- e80b254
backward compatibility older python
amol- 0442ef4
Isolate from host global conf
amol- 9bd9fb7
fixes for windows
amol- b71b6a9
Simplify python version logic
amol- 6220dfd
Make pyproject a template file
amol- 361ea84
Move READMEs to their own template files
amol- 06d2194
Migrate from quarto --shiny to quarto-shiny
amol- 7235a0b
Remove unecessay README
amol- 050926a
Uniform toward AppModes
amol- 73ca08a
uniform toward AppModes all commands
amol- 7317576
handle text decoding
amol- c78da7f
Add --requirements-file option and requirements_file pyproject.toml o…
amol- 2960bd1
temporarily remove quarto-shiny skeleton, not yet supported
amol- 4f2bf3e
quality of life tweaks and --python option
amol- File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ::: mkdocs-click | ||
| :module: rsconnect.main | ||
| :command: quickstart |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,7 +144,7 @@ def handle_bad_response(self, response: HTTPResponse | T, is_httpresponse: bool | |
| if isinstance(response, HTTPResponse): | ||
| if response.exception: | ||
| raise RSConnectException( | ||
| "Exception trying to connect to %s - %s" % (self.url, response.exception), cause=response.exception | ||
| "Could not connect to %s - %s" % (self.url, response.exception), cause=response.exception | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Love this cleanup |
||
| ) | ||
| # Sometimes an ISP will respond to an unknown server name by returning a friendly | ||
| # search page so trap that since we know we're expecting JSON from Connect. This | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish this were
tool.connectrather thantool.rsconnectbut I imagine this was done since the CLI is stillrsconnect(and we aren't migrating away from that yet), yeah?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the best practice is to name the
tooloption exactly like the name of the tool that reads it.So as far as it's named
rsconnectthe option would betool.rsconnect.But we can definitely alias it in the future without too much effort, so that we support both historical and new name if the tool gets renamed.