switch to with-connect for integration tests#355
Open
karawoo wants to merge 11 commits into
Open
Conversation
karawoo
force-pushed
the
kara-with-connect
branch
from
41afd3c to
881a443
Compare
Contributor
Extension release summary🚀 Will release on merge
😴 Changed but won't releaseThe following extensions have code changes but the manifest version hasn't been incremented:
If you intended to release these changes, update the See the contributing guide for details. |
karawoo
force-pushed
the
kara-with-connect
branch
2 times, most recently
from
07e1d51 to
689de97
Compare
karawoo
force-pushed
the
kara-with-connect
branch
from
689de97 to
4829a77
Compare
karawoo
force-pushed
the
kara-with-connect
branch
2 times, most recently
from
efe897d to
4dac19b
Compare
karawoo
force-pushed
the
kara-with-connect
branch
3 times, most recently
from
08bc82c to
bf77738
Compare
karawoo
force-pushed
the
kara-with-connect
branch
2 times, most recently
from
ffed0a9 to
4fc938d
Compare
karawoo
force-pushed
the
kara-with-connect
branch
from
4fc938d to
c1dcd1b
Compare
dotNomad
reviewed
Jun 9, 2026
dotNomad
left a comment
dotNomad
left a comment
Collaborator
There was a problem hiding this comment.
Having reviewed the non-extensions bit so far I think the only thing I'm seeing is that we should up the GitHub action versions and see if CI still passes without issue just to be sure we aren't missing some param name change or something.
| chat-with-content: extensions/chat-with-content/** | ||
| pqr: extensions/pqr/** | ||
|
|
||
| # When infra changed, test all simple extensions; otherwise use the filter output |
Collaborator
There was a problem hiding this comment.
Smart inclusion here for testing this.
Contributor
Author
There was a problem hiding this comment.
it does have the side effect of reporting that extensions have been "changed" (they haven't) but won't be released.
I don't think it's a big deal, but we could try to refactor if it gets confusing.
Collaborator
There was a problem hiding this comment.
I don't think that's a huge deal. Like you said we can adjust in the future if need be.
Comment on lines
+3
to
+5
| # Runs integration tests for ALL extensions against all compatible Connect | ||
| # versions. Catches regressions from upcoming Connect releases even when | ||
| # extension code hasn't changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moves integration tests to use with-connect and adds a weekly scheduled run so that we catch failures on upcoming connect releases even if we're not actively pushing code to this repo
closes #353
the Connect containers used by
with-connecthave specific R and Python versions that are different from the previous integration testing setup, so getting tests to pass required a fair amount of dependency work (and sorry for the size of this diff):@amylin1249 there will probably be some merge conflicts between this and some of your other in-progress PRs so we'll have to sort that out when they start merging.