Skip to content

Fix Windows server build command quoting#2466

Open
timm-u wants to merge 1 commit intopingdotgg:mainfrom
timm-u:codex/windows-build-cli-fix-pr
Open

Fix Windows server build command quoting#2466
timm-u wants to merge 1 commit intopingdotgg:mainfrom
timm-u:codex/windows-build-cli-fix-pr

Conversation

@timm-u
Copy link
Copy Markdown

@timm-u timm-u commented May 2, 2026

What Changed

Fixes the Windows server build path used by apps/server/scripts/cli.ts.

The build command was launching process.execPath with shell: true on Windows. That breaks when the executable path contains spaces, which caused bun run dist:desktop:win:x64 to fail during the server build step with 'C:\Program' is not recognized....

This change removes the Windows shell hop for that specific command, since process.execPath is already an absolute executable path.

Why

Building the Windows desktop installer should work reliably on normal Windows setups, including machines where Node/Bun lives under C:\Program Files\....

This is a small, targeted bug fix:

  • no feature changes
  • no packaging behavior changes beyond fixing the failing build path
  • keeps the command invocation more correct because it avoids unnecessary shell wrapping for an already-resolved executable

I verified that a fresh bun run dist:desktop:win:x64 now succeeds after this change.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Low risk: a small, targeted change to process spawning in the build CLI, affecting only how the bundle command is invoked on Windows.

Overview
Fixes the apps/server build CLI so the build:bundle step no longer uses shell on Windows when spawning process.execPath, avoiding failures when the executable path contains spaces (e.g., C:\Program Files\...).

Reviewed by Cursor Bugbot for commit 3559abe. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix Windows build command quoting by removing shell invocation in buildCmd

On Windows, launching a child process via the shell can fail when process.execPath contains spaces. The shell: process.platform === 'win32' option is removed from the ChildProcess.make call in cli.ts, so the build process is now invoked directly with the absolute executable path.

Macroscope summarized 3559abe.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5441e015-e649-402a-976e-40cb0a8243f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels May 2, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 2, 2026

Approvability

Verdict: Approved

Straightforward bug fix in build tooling that removes shell mode for Windows to fix path quoting issues when paths contain spaces. Minimal scope, clear intent, and no production runtime impact.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant