cloud: mark Step 3 as optional in serverless private endpoint doc#22843
cloud: mark Step 3 as optional in serverless private endpoint doc#22843ti-chi-bot[bot] merged 7 commits intopingcap:masterfrom
Conversation
Clarify that authorizing private endpoints is only needed when restricting access, and that leaving Authorized Networks empty allows all connections. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
ti-chi-bot
Bot
added
contribution
|
Hi @clark1013. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
Bot
added
missing-translation-status
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for setting up private endpoint connections on TiDB Cloud Serverless to clarify that authorizing private endpoints is an optional step. It introduces an information block explaining that all connections are allowed by default if no rules are configured and adjusts the step-by-step instructions accordingly. Feedback has been provided to align headings with sentence case requirements, ensure consistent UI terminology for "Authorized Networks", and remove redundant explanations in the tips section.
|
LGTM |
|
@baiyuqing: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
ti-chi-bot
Bot
added
size/XXL
[LGTM Timeline notifier]Timeline:
|
lilin90
added
the
needs-cherry-pick-release-8.5
lilin90
added
translation/no-need
|
/ok-to-test |
ti-chi-bot
Bot
added
ok-to-test
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
4 participants
Clarify that authorizing private endpoints is only needed when restricting access, and that leaving Authorized Networks empty allows all connections.
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?