Improve DateInterval inference#5486
Open
VincentLanglet wants to merge 2 commits intophpstan:2.1.xfrom
Open
Conversation
VincentLanglet
force-pushed
the
fixDateInterval
branch
2 times, most recently
from
398f653 to
58488b8
Compare
VincentLanglet
force-pushed
the
fixDateInterval
branch
from
9afe071 to
349f5be
Compare
Collaborator
|
This pull request has been marked as ready for review. |
staabm
reviewed
Apr 28, 2026
|
|
||
| foreach ($constantStrings as $constantString) { | ||
| try { | ||
| DateInterval::createFromDateString($constantString->getValue()); |
Contributor
There was a problem hiding this comment.
in the other extensions we suppress warnings with @ on this line
and catch Throwable instead of Exception
Contributor
|
I wonder why issue-bot is not reporting changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersed #5483
Fixes phpstan/phpstan#14479