Fix GH-21869: pdo_pgsql DEALLOCATE in destructor can poison the enclosing transaction.#21870
Open
devnexen wants to merge 2 commits intophp:PHP-8.4from
Open
Fix GH-21869: pdo_pgsql DEALLOCATE in destructor can poison the enclosing transaction.#21870devnexen wants to merge 2 commits intophp:PHP-8.4from
devnexen wants to merge 2 commits intophp:PHP-8.4from
Conversation
…closing transaction. On libpq < 17 the raw DEALLOCATE can fail (e.g. Aurora DSQL rejects it), which aborts the user's transaction and turns the next COMMIT into a silent ROLLBACK. Wrap it in a SAVEPOINT so a failure is contained, and skip it when the transaction is already aborted or the connection is gone.
devnexen
changed the title
devnexen
changed the title
devnexen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On libpq < 17 the raw DEALLOCATE can fail (e.g. Aurora DSQL rejects it),
which aborts the user's transaction and turns the next COMMIT into a
silent ROLLBACK. Wrap it in a SAVEPOINT so a failure is contained, and
skip it when the transaction is already aborted or the connection is gone.