chore(deps): clear vulnerable transitive deps (tar, flatted)#10049
Open
dpage wants to merge 1 commit into
Open
chore(deps): clear vulnerable transitive deps (tar, flatted)#10049dpage wants to merge 1 commit into
dpage wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
WalkthroughThis PR adds a Yarn dependency resolution override for ChangesDependency security resolution
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolves open Dependabot security advisories for transitive npm dependencies that have no direct manifest entry (so Dependabot cannot auto-open fix PRs for them). tar (6 x HIGH): an old tar@6.2.1 was pulled in via ttf2woff2@4.0.5 -> node-gyp@9.4.1 (and node-gyp's make-fetch-happen@10 -> cacache@16 chain). ttf2woff2 6+ switched to an ESM/default export that breaks @vusion/webfonts-generator's callable usage, so rather than bump ttf2woff2 we override its node-gyp to ^11.2.0 via a scoped resolution. That modernises the whole sub-tree (node-gyp 11, make-fetch-happen 14/15, cacache 19/20) onto tar@7.5.16 while keeping ttf2woff2 at 4.0.5 so webfont generation still works. flatted (1 x HIGH): bumped 3.4.1 -> 3.4.2 in the Electron runtime (GHSA-rf6f-7fwh-wjgh). Verified: yarn install builds ttf2woff2's native addon with node-gyp@11, the webpack build regenerates the icon webfonts successfully, and test:js-once passes 829/829. paramiko (covered by pgadmin-org#9927) and elliptic (no fix available upstream) are intentionally left untouched.
3adac1e to
f393902
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears open Dependabot HIGH security advisories for transitive npm dependencies that have no direct manifest entry — so Dependabot can't auto-open fix PRs for them (unlike
paramiko, which has #9927).tar(6 × HIGH — GHSA-9ppj-qmqm-q256 and related)An old
tar@6.2.1was dragged in through a single chain:ttf2woff26+ switched to an ESM/type: moduledefault export, which breaks@vusion/webfonts-generator's callable usage (ttf2woff2(buf)→ "ttf2woff2 is not a function"). So instead of bumpingttf2woff2, this overrides itsnode-gypvia a scoped resolution:That modernises the whole sub-tree (
node-gyp11,make-fetch-happen14/15,cacache19/20) ontotar@7.5.16, while keepingttf2woff2@4.0.5so webfont generation keeps working.node-gyp@9/cacache@16/tar@6.2.1are fully removed fromweb/yarn.lock.flatted(1 × HIGH — GHSA-rf6f-7fwh-wjgh)Bumped
3.4.1 → 3.4.2in the Electronruntime/lockfile (already in-range; the pin was just stale).Out of scope
paramiko(2 × LOW) — already covered by Dependabot PR Python dependency: Bump paramiko from 3.5.1 to 5.0.0 #9927.elliptic(1 × LOW) — no patched version available upstream; tracked only.Test plan
yarn installbuildsttf2woff2's native addon withnode-gyp@11.yarn webpackercompiles successfully and regenerates the icon webfonts (verified the.woff2artifacts are freshly written — this is the step that exercisesttf2woff2).yarn run test:js-once— 829/829 pass, eslint clean.web/yarn.lockchanges are confined to the install/build toolchain; no application-facing dependency shifted.Summary by CodeRabbit