Skip to content

feat: update images to Spock 5.0.7#382

Merged
tsivaprasad merged 1 commit intomainfrom
PLAT-572-update-control-plane-to-support-spock-5-0-7
May 11, 2026
Merged

feat: update images to Spock 5.0.7#382
tsivaprasad merged 1 commit intomainfrom
PLAT-572-update-control-plane-to-support-spock-5-0-7

Conversation

@tsivaprasad
Copy link
Copy Markdown
Contributor

@tsivaprasad tsivaprasad commented May 9, 2026

Summary

This PR updates the pgEdge image tags for Postgres 16.13, 17.9, and 18.3 to use Spock 5.0.7, which includes native PG17+ logical slot failover support.

Changes

  • Update image tags for PG 16.13, 17.9, and 18.3 from spock5.0.6-standard-1 to spock5.0.7-standard-1

  • Updated TestWholeCluster to call spock.wait_for_sync_event only on Patroni primaries, not hot standbys — Spock 5.0.7 tightened this behavior and correctly returns false on standbys where no Spock subscription runs

Testing

  • Updated tests

Checklist

  • Tests added or updated

PLAT-572

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1c59347b-4131-430c-9ea6-5ba76073a93e

📥 Commits

Reviewing files that changed from the base of the PR and between 2c0c395 and 849969f.

📒 Files selected for processing (3)
  • changes/unreleased/Added-20260509-000000.yaml
  • e2e/whole_cluster_test.go
  • server/internal/orchestrator/swarm/images.go

📝 Walkthrough

Walkthrough

This PR upgrades Spock from version 5.0.6 to 5.0.7 across three PostgreSQL versions (16.13, 17.9, 18.3). Docker image tags in the orchestrator configuration are updated, the E2E cluster test is refactored to use matcher-based connection options for replication validation, and a changelog entry documents the addition.

Changes

Spock 5.0.7 Upgrade

Layer / File(s) Summary
Docker Image Configuration
server/internal/orchestrator/swarm/images.go
pgEdge image tags are updated from spock5.0.6 to spock5.0.7 for PostgreSQL 16.13, 17.9, and 18.3 version mappings.
E2E Test Refactoring
e2e/whole_cluster_test.go
TestWholeCluster replication validation is refactored to use ConnectionOptions with WithNode and WithRole("primary") matchers, replacing per-instance iteration, and validates replication sync before assertion.
Release Documentation
changes/unreleased/Added-20260509-000000.yaml
New YAML change record documents the addition of Spock 5.0.7 support on PostgreSQL 16.13, 17.9, and 18.3.

Poem

🐰 A patch hops in, from point-six to seven,
Three Postgres versions reach version heaven,
With Docker tags set and tests aligned,
Spock's newer self leaves old bugs behind,
The cluster replicates, replication sweet!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change of updating Docker images to Spock 5.0.7, which is clearly reflected in all three modified files.
Description check ✅ Passed The description covers all required sections with sufficient detail: Summary explains the purpose, Changes lists the modifications, Testing confirms test updates, and the Checklist indicates tests were updated. Issue is linked (PLAT-572). All essential information is present.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch PLAT-572-update-control-plane-to-support-spock-5-0-7

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@tsivaprasad tsivaprasad merged commit 5dc438d into main May 11, 2026
3 checks passed
@tsivaprasad tsivaprasad deleted the PLAT-572-update-control-plane-to-support-spock-5-0-7 branch May 11, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants