[IGNORE] simplify logic and refactor url pattern#134
Merged
Conversation
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
shahrokni
approved these changes
May 13, 2026
Comment on lines
-66
to
+60
| if (!kind || !name || !version) { | ||
| console.warn(`An invalid Plugin Resource key detected during default plugin lookup: ${np}`); | ||
| const [, , reg, ver] = split; | ||
| if (!ver) { |
Contributor
There was a problem hiding this comment.
Shouldn't we be precautions here?
A compound of key consists of 4 parts from which 3 parts are mandatory based on the definition and the interface. Kind, name, and version. We could be more strict and check the other two (kind and name) as well. Just to make sure the built up compound key has all the essential parts. No?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
refactor to simplify the logic and use a different pattern to make it easy in the backend to parse by differentiate between files using a
~separatorBackend counterpart: perses/perses#4064