chore(BarsIcon): Updat all uses of Bars icons to use RhUiMenuBarsIcon instead#12377
chore(BarsIcon): Updat all uses of Bars icons to use RhUiMenuBarsIcon instead#12377tlabaj wants to merge 1 commit intopatternfly:mainfrom
Conversation
WalkthroughThis pull request updates icon imports across example and demo files in the react-core, react-integration, and react-table packages by replacing Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10-15 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md (1)
10-10: Change line 10 to usedist/esmfor consistency with other imports in this file.All other icon imports in NotificationDrawer.md use
dist/esm; line 10'sdist/jsimport creates unnecessary inconsistency.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md` at line 10, Update the import for RhUiMenuBarsIcon to match the other icon imports by changing the module path from '@patternfly/react-icons/dist/js/icons/rh-ui-menu-bars-icon' to the esm build, i.e. import RhUiMenuBarsIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon'; this keeps the NotificationDrawer.md imports consistent with the rest of the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md`:
- Line 10: Update the import for RhUiMenuBarsIcon to match the other icon
imports by changing the module path from
'@patternfly/react-icons/dist/js/icons/rh-ui-menu-bars-icon' to the esm build,
i.e. import RhUiMenuBarsIcon from
'@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon'; this keeps the
NotificationDrawer.md imports consistent with the rest of the file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 32b2fb26-83c4-46db-8e06-f6152a9e50f3
📒 Files selected for processing (15)
packages/react-core/src/components/Masthead/examples/Masthead.mdpackages/react-core/src/components/Menu/examples/Menu.mdpackages/react-core/src/components/Menu/examples/MenuWithActions.tsxpackages/react-core/src/components/Menu/examples/MenuWithFavorites.tsxpackages/react-core/src/components/Page/examples/Page.mdpackages/react-core/src/demos/CustomMenus/CustomMenus.mdpackages/react-core/src/demos/CustomMenus/examples/ActionsMenuDemo.tsxpackages/react-core/src/demos/Masthead.mdpackages/react-core/src/demos/Nav.mdpackages/react-core/src/demos/NotificationDrawer/NotificationDrawer.mdpackages/react-core/src/demos/Page.mdpackages/react-core/src/demos/RTL/RTL.mdpackages/react-core/src/demos/Wizard/WizardDemo.mdpackages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDemo.tsxpackages/react-table/src/demos/Table.md
|
Preview: https://pf-react-pr-12377.surge.sh A11y report: https://pf-react-pr-12377-a11y.surge.sh |
What: towards #12244
Summary
Replaces
BarsIconwithRhUiMenuBarsIcon(rh-ui-menu-bars-icon) in components, documentation, and the integration demo app so the menu/bars icon uses the Red Hat UI asset.Changes
bars-icontorh-ui-menu-bars-icon.BarsIconwithRhUiMenuBarsIconin affected examples and demos.Scope
MenuWithActions,MenuWithFavorites,ActionsMenuDemo, and shared doc imports in related.mdfiles (Page, Masthead, Nav, CustomMenus, NotificationDrawer, RTL, Wizard, and related demos).Table.mdshared imports.MenuDemo.tsx.Summary by CodeRabbit
Documentation
Chores