Added vscript runtime checksum data#361
Open
betsruner wants to merge 2 commits intop2sr:masterfrom
Open
Conversation
Member
|
The cursor is strong with this one. The signing should be in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue / Solution
This is fixing the issue of SAR only calculating vscript checksums when the plugin is loaded.
This adds a secondary check to the vscript compile execution path. It records the script name, and a checksum of the runtime script buffer to demos.
Notes
Testing
I only tested a chapter run and a single demo (on linux and windows). For the single demo I started the demo a bit into the level to ensure the queuing was working correctly. I'll attach the mdp output to the PR in case anyone wants to have a look.
output.txt