Require resourceKind on confirmDelete#3205
Open
david-crespo wants to merge 1 commit intomainfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
force-pushed
the
resource-kind-labels
branch
from
0210fa7 to
eeecf13
Compare
Collaborator
Author
|
Lol at the status changes. See kitlangton/ghui#4 |
charliepark
approved these changes
May 3, 2026
Contributor
charliepark
left a comment
charliepark
left a comment
There was a problem hiding this comment.
I would maybe prefer Confirm ${resourceKind} deletion over Confirm delete ${resourceKind}, but not a blocker.
Collaborator
Author
|
I think you’re right that there’s something grammatically funny about “Confirm delete snapshot” but I don’t like the passive “deletion” either. Maybe “Delete snapshot” or “Delete snapshot?” |
Contributor
|
Yeah, that's shorter and snappier. I think either with or without the question mark works. Maybe a slight tilt towards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets us say what kind of resource it is in the confirm modal title and in the error toast.