baremetal: add docker_insecure_registries for metalbox to deploy play…

[berendt]

…book

Sets docker_insecure_registries to [metalbox:5001] alongside the existing metalbox.osism.xyz hosts entry so deployed nodes can pull from the metalbox registry over HTTP.

AI-assisted: Claude Code

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• You’re unconditionally overwriting play['vars']['docker_insecure_registries'] in three places; if other registries might already be defined, consider appending/merging instead of replacing the list.
• The same docker_insecure_registries = ['metalbox:5001'] block is duplicated in three branches; consider extracting a small helper or consolidating the common logic to reduce repetition and keep future changes in one place.
• You’re adding metalbox:5001 while the hosts entry uses metalbox.osism.xyz; double-check that Docker will actually resolve metalbox in this context or consider aligning the hostname with the one configured in hosts_additional_entries.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- You’re unconditionally overwriting `play['vars']['docker_insecure_registries']` in three places; if other registries might already be defined, consider appending/merging instead of replacing the list.
- The same `docker_insecure_registries = ['metalbox:5001']` block is duplicated in three branches; consider extracting a small helper or consolidating the common logic to reduce repetition and keep future changes in one place.
- You’re adding `metalbox:5001` while the hosts entry uses `metalbox.osism.xyz`; double-check that Docker will actually resolve `metalbox` in this context or consider aligning the hostname with the one configured in `hosts_additional_entries`.

## Individual Comments

### Comment 1
<location path="osism/commands/baremetal.py" line_range="305-307" />
<code_context>
                             play["vars"]["hosts_additional_entries"] = {
                                 "metalbox.osism.xyz": metalbox_ip
                             }
+                            play["vars"]["docker_insecure_registries"] = [
+                                "metalbox:5001"
+                            ]
                     if (
                         "netplan_parameters" in node.extra
</code_context>
<issue_to_address>
**issue (bug_risk):** Avoid overwriting any existing `docker_insecure_registries` that might already be present.

If `play["vars"]` may already define `docker_insecure_registries` (from other logic or config), this will overwrite it. Instead, merge with any existing list and only add `"metalbox:5001"` if it isn’t already present.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (bug_risk): Avoid overwriting any existing docker_insecure_registries that might already be present.

If play["vars"] may already define docker_insecure_registries (from other logic or config), this will overwrite it. Instead, merge with any existing list and only add "metalbox:5001" if it isn’t already present.