Skip to content

Sync Pipfile with requirements*.txt#2254

Open
berendt wants to merge 1 commit intomainfrom
sync-pipenv
Open

Sync Pipfile with requirements*.txt#2254
berendt wants to merge 1 commit intomainfrom
sync-pipenv

Conversation

@berendt
Copy link
Copy Markdown
Member

@berendt berendt commented May 4, 2026

Pipfile drifted from the requirements files: it was missing several runtime packages from requirements.txt and still pinned dependencies that were removed in e235a7d (sonic-yang-mgmt → generated Pydantic schemas) along with unused entries.

  • Add boto3, fastapi, tabulate, uvicorn[standard], websockets from requirements.txt.
  • Add pydantic from requirements.sonic.txt.
  • Drop sonic-yang-mgmt and pyang (replaced by committed Pydantic schemas; pyang is build-time only for tools/sonic_yang_to_pydantic.py).
  • Drop huey (no longer referenced anywhere in the codebase).
  • Regenerate Pipfile.lock.

AI-assisted: Claude Code

Pipfile drifted from the requirements files: it was missing several
runtime packages from requirements.txt and still pinned dependencies
that were removed in e235a7d (sonic-yang-mgmt → generated Pydantic
schemas) along with unused entries.

- Add boto3, fastapi, tabulate, uvicorn[standard], websockets from
  requirements.txt.
- Add pydantic from requirements.sonic.txt.
- Drop sonic-yang-mgmt and pyang (replaced by committed Pydantic
  schemas; pyang is build-time only for tools/sonic_yang_to_pydantic.py).
- Drop huey (no longer referenced anywhere in the codebase).
- Regenerate Pipfile.lock.

AI-assisted: Claude Code

Signed-off-by: Christian Berendt <berendt@osism.tech>
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since pyang is still needed for tools/sonic_yang_to_pydantic.py, consider adding it to [dev-packages] or a dedicated tooling requirements file so contributors can still run the generator without having to discover/install it manually.
  • If any of the newly added runtime deps (e.g., pydantic>=2, fastapi, uvicorn[standard]) have constraints or pins that differ from the various requirements*.txt files, it would be good to ensure they are aligned here to avoid future drift between Pipenv and pip-based environments.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `pyang` is still needed for `tools/sonic_yang_to_pydantic.py`, consider adding it to `[dev-packages]` or a dedicated tooling requirements file so contributors can still run the generator without having to discover/install it manually.
- If any of the newly added runtime deps (e.g., `pydantic>=2`, `fastapi`, `uvicorn[standard]`) have constraints or pins that differ from the various `requirements*.txt` files, it would be good to ensure they are aligned here to avoid future drift between Pipenv and pip-based environments.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant