Conversation
Pipfile drifted from the requirements files: it was missing several runtime packages from requirements.txt and still pinned dependencies that were removed in e235a7d (sonic-yang-mgmt → generated Pydantic schemas) along with unused entries. - Add boto3, fastapi, tabulate, uvicorn[standard], websockets from requirements.txt. - Add pydantic from requirements.sonic.txt. - Drop sonic-yang-mgmt and pyang (replaced by committed Pydantic schemas; pyang is build-time only for tools/sonic_yang_to_pydantic.py). - Drop huey (no longer referenced anywhere in the codebase). - Regenerate Pipfile.lock. AI-assisted: Claude Code Signed-off-by: Christian Berendt <berendt@osism.tech>
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since
pyangis still needed fortools/sonic_yang_to_pydantic.py, consider adding it to[dev-packages]or a dedicated tooling requirements file so contributors can still run the generator without having to discover/install it manually. - If any of the newly added runtime deps (e.g.,
pydantic>=2,fastapi,uvicorn[standard]) have constraints or pins that differ from the variousrequirements*.txtfiles, it would be good to ensure they are aligned here to avoid future drift between Pipenv and pip-based environments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `pyang` is still needed for `tools/sonic_yang_to_pydantic.py`, consider adding it to `[dev-packages]` or a dedicated tooling requirements file so contributors can still run the generator without having to discover/install it manually.
- If any of the newly added runtime deps (e.g., `pydantic>=2`, `fastapi`, `uvicorn[standard]`) have constraints or pins that differ from the various `requirements*.txt` files, it would be good to ensure they are aligned here to avoid future drift between Pipenv and pip-based environments.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipfile drifted from the requirements files: it was missing several runtime packages from requirements.txt and still pinned dependencies that were removed in e235a7d (sonic-yang-mgmt → generated Pydantic schemas) along with unused entries.
AI-assisted: Claude Code