Skip to content

Add unit tests for SONiC config_generator port/interface helpers #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
berendt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add unit tests for SONiC config_generator port/interface helpers #2246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions osism/tasks/conductor/sonic/config_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,10 +628,12 @@ def _add_missing_breakout_ports(
master_port = breakout_info["breakout_ports"][port_name]["master"]

# Override with individual breakout port speed from NetBox if available
# Note: NetBox stores speed in kbps, SONiC expects Mbps (divide by 1000)
if port_name in netbox_interfaces and netbox_interfaces[port_name]["speed"]:
port_speed = str(netbox_interfaces[port_name]["speed"])
netbox_speed = netbox_interfaces[port_name]["speed"]
port_speed = str(int(netbox_speed) // 1000)
logger.debug(
f"Using NetBox speed {port_speed} for missing breakout port {port_name}"
f"Using NetBox speed {netbox_speed} kbps -> {port_speed} Mbps for missing breakout port {port_name}"
)
elif master_port in breakout_info["breakout_cfgs"]:
# Fallback to extracting speed from breakout mode
Expand Down
Loading