Skip to content

✨ use AlwaysAllow UnhealthyPodEvictionPolicy option in PDBs #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atiratree wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ use AlwaysAllow UnhealthyPodEvictionPolicy option in PDBs #2688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helm/olmv1/templates/poddisruptionbudget-olmv1-system-catalogd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ spec:
{{- if .Values.options.catalogd.podDisruptionBudget.maxUnavailable }}
maxUnavailable: {{ .Values.options.catalogd.podDisruptionBudget.maxUnavailable }}
{{- end }}
unhealthyPodEvictionPolicy: AlwaysAllow
selector:
matchLabels:
control-plane: catalogd-controller-manager
Expand Down
1 change: 1 addition & 0 deletions helm/olmv1/templates/poddisruptionbudget-olmv1-system-operator-controller.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ spec:
{{- if .Values.options.operatorController.podDisruptionBudget.maxUnavailable }}
maxUnavailable: {{ .Values.options.operatorController.podDisruptionBudget.maxUnavailable }}
{{- end }}
unhealthyPodEvictionPolicy: AlwaysAllow
Copy link
Copy Markdown
Author

@atiratree atiratree May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a minimum supported k8s version for OLM?

Copy link
Copy Markdown
Contributor

@tmshort tmshort May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The k8s API in go.mod is 0.35.x, so that should be considered the minimum. Since these charts are used for helm template and not helm install, the .Capabilities.KubeVersion.Version may not be known, and shouldn't be depended on (it's not used anywhere else)

selector:
matchLabels:
control-plane: operator-controller-controller-manager
Expand Down
2 changes: 2 additions & 0 deletions manifests/experimental-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ metadata:
olm.operatorframework.io/feature-set: experimental-e2e
spec:
minAvailable: 1
unhealthyPodEvictionPolicy: AlwaysAllow
selector:
matchLabels:
control-plane: catalogd-controller-manager
Expand All @@ -117,6 +118,7 @@ metadata:
olm.operatorframework.io/feature-set: experimental-e2e
spec:
minAvailable: 1
unhealthyPodEvictionPolicy: AlwaysAllow
selector:
matchLabels:
control-plane: operator-controller-controller-manager
Expand Down
2 changes: 2 additions & 0 deletions manifests/experimental.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ metadata:
olm.operatorframework.io/feature-set: experimental
spec:
minAvailable: 1
unhealthyPodEvictionPolicy: AlwaysAllow
selector:
matchLabels:
control-plane: catalogd-controller-manager
Expand All @@ -117,6 +118,7 @@ metadata:
olm.operatorframework.io/feature-set: experimental
spec:
minAvailable: 1
unhealthyPodEvictionPolicy: AlwaysAllow
selector:
matchLabels:
control-plane: operator-controller-controller-manager
Expand Down
2 changes: 2 additions & 0 deletions manifests/standard-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ metadata:
olm.operatorframework.io/feature-set: standard-e2e
spec:
minAvailable: 1
unhealthyPodEvictionPolicy: AlwaysAllow
selector:
matchLabels:
control-plane: catalogd-controller-manager
Expand All @@ -117,6 +118,7 @@ metadata:
olm.operatorframework.io/feature-set: standard-e2e
spec:
minAvailable: 1
unhealthyPodEvictionPolicy: AlwaysAllow
selector:
matchLabels:
control-plane: operator-controller-controller-manager
Expand Down
2 changes: 2 additions & 0 deletions manifests/standard.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ metadata:
olm.operatorframework.io/feature-set: standard
spec:
minAvailable: 1
unhealthyPodEvictionPolicy: AlwaysAllow
selector:
matchLabels:
control-plane: catalogd-controller-manager
Expand All @@ -117,6 +118,7 @@ metadata:
olm.operatorframework.io/feature-set: standard
spec:
minAvailable: 1
unhealthyPodEvictionPolicy: AlwaysAllow
selector:
matchLabels:
control-plane: operator-controller-controller-manager
Expand Down
Loading