fix: ClusterDeployedOperatorExtension should alway apply CRDs before test#3312
Merged
csviri merged 5 commits intooperator-framework:mainfrom Apr 24, 2026
Merged
Conversation
…test Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
xstefank
approved these changes
Apr 24, 2026
Collaborator
xstefank
left a comment
xstefank
left a comment
There was a problem hiding this comment.
so it was relying on the LocallyRun case to deploy CRDs?
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the JUnit ClusterDeployedOperatorExtension lifecycle to apply CRDs before running tests, by moving CRD application into the beforeAll phase.
Changes:
- Introduces a
beforeAllImpl(...)override intended to apply CRDs before executing superclassbeforeAlllogic. - Renames/extracts the prior
before(...)logic into a newapplyCrds(...)method.
Collaborator
Author
It seems to :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros a_meszaros@apple.com